STM32WBA2: Add Bluetooth LE support#364
STM32WBA2: Add Bluetooth LE support#364HoZHel wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
HoZHel
changed the title
| endif() | ||
|
|
||
| # Distinguish STM32WBA6x from STM32WBA5x lines | ||
| # Distinguish between WBA series SoCs |
There was a problem hiding this comment.
Nit:
| # Distinguish between WBA series SoCs | |
| # Distinguish between lines of the STM32WBA series |
Also, we could declare CONFIG_SOC_STM32WBAxX_LINE_DEVICE options on Zephyr side (in a similar fashion to SOC_STM32F10X_xxx_LINE_DEVICE) and use them here instead to avoid explicit SoC checks - this makes adding SoCs easier as no hal_stm32 update is required.
cc @erwango
There was a problem hiding this comment.
Agreed, but I'm having hard times to imagine that we'll have much more SoCs of this kind here.
There was a problem hiding this comment.
Even by introducing CONFIG_SOC_STM32WBAxX_LINE_DEVICE, hal_stm32 update is still needed to set libname_prefix and introduce new BLOBS.
There was a problem hiding this comment.
@mathieuchopstm, I applied your suggested change.
|
@HoZHel Please rebase |
HoZHel
force-pushed
the
WBA2_BLE_support
branch
from
472cb57 to
8ffcd51
Compare
Done |
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
Could you refine the commit message header line. E.g.:
-STM32WBA2: Add Bluetooth LE
+lib: stm32wba: Add Bluetooth LE link layer for WBA2xProvide Bluetooth LE support for STM32WBA2. Add WBA2 basic and full BLE libraries (BLOBS). Signed-off-by: Ali Hozhabri <ali.hozhabri@st.com>
HoZHel
force-pushed
the
WBA2_BLE_support
branch
from
8ffcd51 to
50bd0a9
Compare
Done. |
4 participants
Provide Bluetooth LE support for STM32WBA2.
Add WBA2 basic and full BLE libraries (BLOBS).
Supplementary PR #108116